Command history buffer shared with programs/clear command

SynapticBytes

As the title says, it seems that the command history buffer used for issuing command line statements is also being used by any "input" command in code.

I was debugging my code by using a dummy input command to pause while I reviewed some debug prints. Then when I went back to the command line to do my usual 3-up arrow tape for "reset/load/run" and there was a millions blank lines in my history. You can use the up arrow to scroll through the history while waiting for data entry.

A secondary issue, which may or may not be related, is that I am issuing a "clear" command on the text display after hitting enter, to give me a fresh screen for more text, but my next printed text appears at the bottom of the screen. I would assume a clear would reset the cursor position to the top of the screen? Or is it simply setting the next location to the 0,0 pixel?

jstrout

Yes, the input history buffer is shared between the command-line and the input function. There is a limit to how big this history will grow, however. I think "millions" might be a bit of an exaggeration. 😆

I have been considering not storing blanks in this history, though. Would that help?

As for clear, I came to the same conclusion as you (i.e. it should set text.row to 25 rather than 0). This change will be in Mini Micro v0.8, which I hope to get out sometime in the next few weeks. (But I can sneak you an advance copy if you like.)

SynapticBytes

Haha, i”m prone to exaggeration, so yes “millions” was a stretch.

Not storing blanks is probably a good idea.

The fact the arrow keys are so commonly used for movement and also the command history complicates the issue. I don’t suppose you’d consider requiting a modifier key to navigate the buffer? I know it makes using it less intuitive and slightly harder, but I can foresee others having issues with their code of they don’t cater for it. Just a suggestion.

jstrout

OK, I think I've missed something. How are the arrow keys involved?

...ah, I may have an idea. You probably want a key.clear at the bottom of your main loop, right before you exit. This clears the keyboard buffer. Otherwise, all those key presses you were using for movement have just piled up and then spew into the command console.

(I see some of the demos do this and some do not. I should perhaps be more consistent about it.)

I don't feel like this is really a command-history issue, though; you'd have a similar problem if you used WASD for movement, or anything else.

SynapticBytes

Yes you’ve hit most of it, and I did discover key.clear and added it when I leave the game, but it’s also an issue when you have an input command, with random text (i.e. previous command line entries) appearing when you stop for input. This also can be fixed with a key.clear though.